initial design for automation chain expansion and FG/LN feeds removal #11139
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
Go solidity wrappers are out-of-date, regenerate them via the |
|
Go solidity wrappers are out-of-date, regenerate them via the |
| @@ -361,6 +369,12 @@ func (r *EvmRegistry) simulatePerformUpkeeps(ctx context.Context, checkResults [ | |||
| r.lggr.Warnf("upkeepId %s is not eligible after simulation of perform", checkResults[idx].UpkeepID.String()) | |||
| checkResults[performToKeyIdx[i]].Eligible = false | |||
| checkResults[performToKeyIdx[i]].IneligibilityReason = uint8(encoding.UpkeepFailureReasonSimulationFailed) | |||
| } else { | |||
| // at this point, the core node knows the exact perform data of the upkeep and the call data to L1. | |||
| // it can calculate a relatively accurate L1 gas cost | |||
There was a problem hiding this comment.
this may introduce some delays between when L1 gas cost is calculated and when users are charged.
but currently the data feeds are updated every 15 mins or the deviation is above x %
|
Go solidity wrappers are out-of-date, regenerate them via the |
| @@ -190,6 +190,14 @@ func (r *EvmRegistry) checkUpkeeps(ctx context.Context, payloads []ocr2keepers.U | |||
| continue | |||
| } | |||
|
|
|||
| // call gas estimator (GE) component to get L2 gas cost | |||
| // estimatedL1GasCost = GE.getL1GasCost(chain_id, block_number, block_hash, estimated_tx_call_data) | |||
There was a problem hiding this comment.
currently, core node does not know about maxPerformDataSize
There was a problem hiding this comment.
Ryan: can we estimate with more accurate call data size?
|
Go solidity wrappers are out-of-date, regenerate them via the |
|
Go solidity wrappers are out-of-date, regenerate them via the |
|
Go solidity wrappers are out-of-date, regenerate them via the |
|
Go solidity wrappers are out-of-date, regenerate them via the |
|
Go solidity wrappers are out-of-date, regenerate them via the |
|
Go solidity wrappers are out-of-date, regenerate them via the |
|
SonarQube Quality Gate
See analysis details on SonarQube Fix issues before they fail your Quality Gate with |
|
Go solidity wrappers are out-of-date, regenerate them via the |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
No description provided.